fix(cmd): parse withdraw fee using transaction options #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
==========================================
+ Coverage 75.07% 76.22% +1.14%
==========================================
Files 234 236 +2
Lines 12156 18240 +6084
==========================================
+ Hits 9126 13903 +4777
- Misses 2582 3879 +1297
- Partials 448 458 +10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The transaction constructor includes an option to parse and set the fee correctly. However, this functionality was missing for the "withdraw" transaction. This PR addresses the issue by using
OptionFeeFromStringto handle the transaction fee.Workaround
To use the current command, users must set the fee manually as an option in the command, like so:
Related Issue(s)