Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Add new pusnotifications azure functions app #465

Merged
merged 18 commits into from
Mar 23, 2021
Merged

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Mar 18, 2021

Add the configurations for a brand new Azure Functions dedicated to consume push notifications-related messages.

This app is basically a copy of functions_app_async which is meant to only consume messages passed through notification_queue. In the long run, such app will be replaced by this one (for the part regarding push notifications).

Notable differences:

  • use node 12.18.0 instead of 10.14.1;
  • use a wrong queue name as we don't want this function to consume production messages on first instance;
  • every reference to unused resources has been removed.

Application code is found at https://github.com/pagopa/io-functions-pushnotifications


locals {
commonvars = read_terragrunt_config(find_in_parent_folders("commonvars.hcl"))
service_api_url = local.commonvars.locals.service_api_url
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Service api url is not used


locals {
commonvars = read_terragrunt_config(find_in_parent_folders("commonvars.hcl"))
service_api_url = local.commonvars.locals.service_api_url
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not useful

Emanuele De Cupis and others added 4 commits March 18, 2021 13:24
…ion_app_slot_staging/terragrunt.hcl

Co-authored-by: Walter Traspadini <walter.traspadini@pagopa.it>
…ion_app_slot_staging/terragrunt.hcl

Co-authored-by: Walter Traspadini <walter.traspadini@pagopa.it>
…ion_app/terragrunt.hcl

Co-authored-by: Walter Traspadini <walter.traspadini@pagopa.it>
…t/terragrunt.hcl

Co-authored-by: Pasquale De Vita <59291437+pasqualedevita@users.noreply.github.com>
@pasqualedevita
Copy link
Contributor

pasqualedevita commented Mar 18, 2021

@balanza we reached max length for storage account named iopstfn3pushnotifications (25 chars and max is 24)
What do u think to rename all resources in pushnotification?

Error: name ("iopstfn3pushnotifications") can only consist of lowercase letters and numbers, and must be between 3 and 24 characters long

@balanza
Copy link
Contributor Author

balanza commented Mar 18, 2021

we reached max length for storage account

🤦

I'd say iopstfn3pushntfcns or iopstfn3pushnotif, so the prefix is preserved

@pasqualedevita
Copy link
Contributor

we reached max length for storage account

🤦

I'd say iopstfn3pushntfcns or iopstfn3pushnotif, so the prefix is preserved

I prefer iopstfn3pushnotif less tricky to write :)))

@pasqualedevita
Copy link
Contributor

Not yet, I'm doing the fix

@pasqualedevita
Copy link
Contributor

@gquadrati @balanza there was an issue on function_app_slot
here commit diff
68312ec

source = "git::git@github.com:pagopa/io-infrastructure-modules-new.git//azurerm_function_app?ref=v3.0.2" creates a new function_app instead a function_app_slot ;)

@pasqualedevita
Copy link
Contributor

Status: applied

@pasqualedevita pasqualedevita merged commit 4e7b391 into master Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants