Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change APIM product #8

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: Change APIM product #8

merged 2 commits into from
Dec 13, 2024

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Dec 13, 2024

List of Changes

  • changed apim product in order to use common spontaneous payment apim product
  • added organizationFiscalCode field to paymentOption model
  • updated openapi
  • updated integration tests

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Comment on lines +53 to +54
description = "Fiscal code related to the organization targeted by this transfer.",
example = "00000000000")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
description = "Fiscal code related to the organization targeted by this transfer.",
example = "00000000000")
description = "Fiscal code related to the organization targeted by this transfer.",
example = "00000000000")

@@ -59,6 +59,7 @@ void buildMbdPaymentOptionTestSuccess() throws Exception {
assertNotNull(paymentOption.getDueDate());
assertNotNull(paymentOption.getRetentionDate());
assertFalse(paymentOption.getIsPartialPayment());
assertEquals(request.getProperties().getCiFiscalCode(), paymentOption.getOrganizationFiscalCode());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[google-java-format] reported by reviewdog 🐶

Suggested change
assertEquals(request.getProperties().getCiFiscalCode(), paymentOption.getOrganizationFiscalCode());
assertEquals(
request.getProperties().getCiFiscalCode(), paymentOption.getOrganizationFiscalCode());

@pasqualespica pasqualespica merged commit 4826649 into main Dec 13, 2024
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants