Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-215] chore: Add service customer id #79

Merged
merged 2 commits into from
Nov 23, 2023
Merged

[PRDP-215] chore: Add service customer id #79

merged 2 commits into from
Nov 23, 2023

Conversation

gioelemella
Copy link
Collaborator

List of Changes

  • added new field serviceCustomerId and set to biz-event id
  • removed useless field transaction.id
  • updated unit tests
  • fixed unit test after merge of authorization code pr [PRDP-212] fix: Authorization code #78

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@gioelemella gioelemella changed the title [PRDP-215] fix: Add service customer id [PRDP-215] chore: Add service customer id Nov 21, 2023
pasqualespica
pasqualespica approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit a59b196 into main Nov 23, 2023
17 of 24 checks passed
@github-actions GitHub Actions
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [patch, minor, major, skip]

@github-actions GitHub Actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@gioelemella gioelemella

Labels
size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gioelemella @pasqualespica