From fd5d36ab57d25f93c5b09d986d46e5f1127e9afa Mon Sep 17 00:00:00 2001
From: Manuel Rafeli <manuel.rafeli@pagopa.it>
Date: Wed, 20 Nov 2024 10:31:17 +0100
Subject: [PATCH] [SELC-5509] ops: Set private ip address to Namirial SWS
 Container  (#609)

---
 .../namirial-sign/container_group.tf          | 22 +++++--------------
 infra/container_apps/namirial-sign/data.tf    |  5 +++++
 .../namirial-sign/env/prod/terraform.tfvars   |  2 +-
 infra/container_apps/namirial-sign/subnet.tf  | 16 ++++++++++++++
 .../container_apps/namirial-sign/variables.tf |  6 +++++
 .../env/dev/terraform.tfvars                  |  2 +-
 .../env/prod/terraform.tfvars                 |  2 +-
 .../env/uat/terraform.tfvars                  |  2 +-
 8 files changed, 37 insertions(+), 20 deletions(-)
 create mode 100644 infra/container_apps/namirial-sign/subnet.tf

diff --git a/infra/container_apps/namirial-sign/container_group.tf b/infra/container_apps/namirial-sign/container_group.tf
index e924534b6..7cd2bab24 100644
--- a/infra/container_apps/namirial-sign/container_group.tf
+++ b/infra/container_apps/namirial-sign/container_group.tf
@@ -1,12 +1,16 @@
+
+# when create a new one container, you should put ./custom.properties file inside selcdnamirialswsst/selc-d-namirial-sws-share
+# pay attention to set this file only when you want to reset Namirial config properties
+
 resource "azurerm_container_group" "namirial_sws_cg" {
 
   count               = var.enable_sws ? 1 : 0
   name                = "${local.project}-namirial-sws-cg"
   location            = data.azurerm_resource_group.rg_contracts_storage.location
   resource_group_name = data.azurerm_resource_group.rg_contracts_storage.name
-  ip_address_type     = "Public"
-  dns_name_label      = "${local.project}-namirial-sws-cg"
+  ip_address_type     = "Private"
   os_type             = "Linux"
+  subnet_ids          = [azurerm_subnet.namirial_sws_snet.id]
 
   image_registry_credential {
     server   = "index.docker.io"
@@ -66,19 +70,5 @@ resource "azurerm_container_group" "namirial_sws_cg" {
     }
   }
 
-  provisioner "local-exec" {
-    command = <<EOT
-      az storage file upload \
-        --account-name ${azurerm_storage_account.namirial_sws_storage_account[0].name} \
-        --account-key ${azurerm_storage_account.namirial_sws_storage_account[0].primary_access_key} \
-        --share-name ${azurerm_storage_share.namirial_sws_storage_share[0].name} \
-        --source "custom.properties" \
-        --path "custom.properties" \
-    EOT
-
-    # Ensure it only runs on first creation
-    when = create
-  }
-
   tags = var.tags
 }
\ No newline at end of file
diff --git a/infra/container_apps/namirial-sign/data.tf b/infra/container_apps/namirial-sign/data.tf
index 180333d66..91d2c306d 100644
--- a/infra/container_apps/namirial-sign/data.tf
+++ b/infra/container_apps/namirial-sign/data.tf
@@ -20,4 +20,9 @@ data "azurerm_key_vault_secret" "hub_docker_pwd" {
 data "azurerm_log_analytics_workspace" "log_analytics" {
   name                = "${local.project}-law"
   resource_group_name = "${local.project}-monitor-rg"
+}
+
+data "azurerm_virtual_network" "vnet_selc" {
+  name                = "${local.project}-vnet"
+  resource_group_name = "${local.project}-vnet-rg"
 }
\ No newline at end of file
diff --git a/infra/container_apps/namirial-sign/env/prod/terraform.tfvars b/infra/container_apps/namirial-sign/env/prod/terraform.tfvars
index 5956f9c6b..01f4e65e7 100644
--- a/infra/container_apps/namirial-sign/env/prod/terraform.tfvars
+++ b/infra/container_apps/namirial-sign/env/prod/terraform.tfvars
@@ -17,5 +17,5 @@ container_config = {
 }
 
 enable_sws = true
-
+cidr_subnet_namirial_sws = ["10.1.150.0/29"]
 environment_variables = {}
diff --git a/infra/container_apps/namirial-sign/subnet.tf b/infra/container_apps/namirial-sign/subnet.tf
new file mode 100644
index 000000000..1af69ff46
--- /dev/null
+++ b/infra/container_apps/namirial-sign/subnet.tf
@@ -0,0 +1,16 @@
+resource "azurerm_subnet" "namirial_sws_snet" {
+  name                                          = "${local.project}-namirial-sws-snet"
+  resource_group_name                           = "${local.project}-vnet-rg"
+  virtual_network_name                          = data.azurerm_virtual_network.vnet_selc.name
+  address_prefixes                              = var.cidr_subnet_namirial_sws
+  private_link_service_network_policies_enabled = true
+  private_endpoint_network_policies_enabled     = false
+
+  delegation {
+    name = "delegation"
+    service_delegation {
+      name    = "Microsoft.ContainerInstance/containerGroups"
+      actions = ["Microsoft.Network/virtualNetworks/subnets/action"]
+    }
+  }
+}
\ No newline at end of file
diff --git a/infra/container_apps/namirial-sign/variables.tf b/infra/container_apps/namirial-sign/variables.tf
index 35ff1259f..ddf3e37f9 100644
--- a/infra/container_apps/namirial-sign/variables.tf
+++ b/infra/container_apps/namirial-sign/variables.tf
@@ -41,4 +41,10 @@ variable "container_config" {
     cpu    = number
     memory = number
   })
+}
+
+variable "cidr_subnet_namirial_sws" {
+  type        = list(string)
+  description = "Cosmosdb pnpg address space."
+  default     = ["10.1.154.0/29"]
 }
\ No newline at end of file
diff --git a/infra/functions/onboarding-functions/env/dev/terraform.tfvars b/infra/functions/onboarding-functions/env/dev/terraform.tfvars
index 5187aa9b5..06192c148 100644
--- a/infra/functions/onboarding-functions/env/dev/terraform.tfvars
+++ b/infra/functions/onboarding-functions/env/dev/terraform.tfvars
@@ -106,7 +106,7 @@ app_settings = {
 
   ##NAMIRIAL SIGNATURE
   "PAGOPA_SIGNATURE_SOURCE"                 = "disabled",
-  "NAMIRIAL_BASE_URL"                       = "http://selc-d-namirial-sws-cg.westeurope.azurecontainer.io:8080",
+  "NAMIRIAL_BASE_URL"                       = "http://10.1.154.4:8080",
   "NAMIRIAL_SIGN_SERVICE_IDENTITY_USER"     = "@Microsoft.KeyVault(SecretUri=https://selc-d-kv.vault.azure.net/secrets/namirial-sign-service-user/)",
   "NAMIRIAL_SIGN_SERVICE_IDENTITY_PASSWORD" = "@Microsoft.KeyVault(SecretUri=https://selc-d-kv.vault.azure.net/secrets/namirial-sign-service-psw/)"
 }
\ No newline at end of file
diff --git a/infra/functions/onboarding-functions/env/prod/terraform.tfvars b/infra/functions/onboarding-functions/env/prod/terraform.tfvars
index b8c2c30a4..ab83f3654 100644
--- a/infra/functions/onboarding-functions/env/prod/terraform.tfvars
+++ b/infra/functions/onboarding-functions/env/prod/terraform.tfvars
@@ -118,7 +118,7 @@ app_settings = {
   "JWT_TOKEN_KID"                                  = "@Microsoft.KeyVault(SecretUri=https://selc-p-kv.vault.azure.net/secrets/jwt-kid/)"
 
   ##NAMIRIAL SIGNATURE
-  "NAMIRIAL_BASE_URL"                       = "http://selc-p-namirial-sws-cg.westeurope.azurecontainer.io:8080",
+  "NAMIRIAL_BASE_URL"                       = "http://10.1.150.4:8080",
   "NAMIRIAL_SIGN_SERVICE_IDENTITY_USER"     = "@Microsoft.KeyVault(SecretUri=https://selc-p-kv.vault.azure.net/secrets/namirial-sign-service-user/)",
   "NAMIRIAL_SIGN_SERVICE_IDENTITY_PASSWORD" = "@Microsoft.KeyVault(SecretUri=https://selc-p-kv.vault.azure.net/secrets/namirial-sign-service-psw/)"
 }
\ No newline at end of file
diff --git a/infra/functions/onboarding-functions/env/uat/terraform.tfvars b/infra/functions/onboarding-functions/env/uat/terraform.tfvars
index ab33736ce..dfa88f580 100644
--- a/infra/functions/onboarding-functions/env/uat/terraform.tfvars
+++ b/infra/functions/onboarding-functions/env/uat/terraform.tfvars
@@ -117,7 +117,7 @@ app_settings = {
   "JWT_TOKEN_KID"                                  = "@Microsoft.KeyVault(SecretUri=https://selc-u-kv.vault.azure.net/secrets/jwt-kid/)"
 
   ##NAMIRIAL SIGNATURE
-  "NAMIRIAL_BASE_URL"                       = "http://selc-u-namirial-sws-cg.westeurope.azurecontainer.io:8080",
+  "NAMIRIAL_BASE_URL"                       = "http://10.1.154.4:8080",
   "NAMIRIAL_SIGN_SERVICE_IDENTITY_USER"     = "@Microsoft.KeyVault(SecretUri=https://selc-u-kv.vault.azure.net/secrets/namirial-sign-service-user/)",
   "NAMIRIAL_SIGN_SERVICE_IDENTITY_PASSWORD" = "@Microsoft.KeyVault(SecretUri=https://selc-u-kv.vault.azure.net/secrets/namirial-sign-service-psw/)"
 }
\ No newline at end of file