Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the buildpack to skip #232

Open
dmikusa opened this issue Sep 15, 2023 · 0 comments
Open

Allow the buildpack to skip #232

dmikusa opened this issue Sep 15, 2023 · 0 comments
Labels
hacktoberfest Hacktoberfest eligible note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Sep 15, 2023

Describe the Enhancement

In some cases, you may have an off-the-shelf WAR file that you are trying to deploy. It may contain a Main-Class entry for "reasons" and because it's off-the-shelf you cannot change that easily. In this scenario, the executable-jar buildpack will run first and see the Main-Class and incorrectly try to run it.

We should have a way to override the default behavior to tell executable-jar to skip.

Possible Solution

Add an env variable that disables the executable-jar buildpack, like BP_EXECUTABLE_JAR_DISABLED. It would default to false. When true, it would just cause the buildpack to fail detection, which in turn would make it skip.

Motivation

See Above.

@dmikusa dmikusa added type:enhancement A general enhancement note:ideal-for-contribution An issue that a contributor can help us with labels Sep 15, 2023
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest eligible note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants