Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a top level generic log emitter to scribe #105

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Conversation

sophiewigmore
Copy link
Member

@sophiewigmore sophiewigmore commented Jan 5, 2021

Thanks for contributing. To speed up the process of reviewing your pull request
please provide us with:

  • A short explanation of the proposed change:

Adds a top level generic log emitter to the scribe package.

  • An explanation of the use cases your change enables:

Adds scribe.Emitter object for logging. This PR also moves jam specific cargo functions into jam/internal to avoid import cycles.

Please confirm the following:

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have added an integration test, if necessary.

cc @ForestEckhardt

Sophie Wigmore added 3 commits December 17, 2020 20:24
Signed-off-by: Forest Eckhardt <feckhardt@pivotal.io>
- Adds function that prints out dependency information as well as
deprecation warnings

Signed-off-by: Forest Eckhardt <feckhardt@pivotal.io>
@sophiewigmore sophiewigmore marked this pull request as ready for review January 5, 2021 18:42
@sophiewigmore sophiewigmore requested a review from a team as a code owner January 5, 2021 18:42
@sophiewigmore
Copy link
Member Author

sophiewigmore commented Jan 5, 2021

@ryanmoran after this is merged, please do not cut a release until occam 0.0.23 changes have been rolled out to all of the buildpacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants