Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds draft package #86

Merged
merged 6 commits into from
Feb 11, 2021
Merged

Adds draft package #86

merged 6 commits into from
Feb 11, 2021

Conversation

ForestEckhardt
Copy link
Contributor

  • This package implements a type that is meant to be a generic Buildpack
    Plan entry resolves as well as a LayerType merger

ryanmoran
ryanmoran reviewed Nov 19, 2020
View reviewed changes
judge/init_test.go Outdated Show resolved Hide resolved
judge/plan_entry_handler.go Outdated Show resolved Hide resolved
@ForestEckhardt ForestEckhardt changed the title Adds judge package Adds draft package Dec 14, 2020
@ForestEckhardt ForestEckhardt marked this pull request as ready for review January 29, 2021 20:53
@ForestEckhardt ForestEckhardt requested a review from a team as a code owner January 29, 2021 20:53
sophiewigmore
sophiewigmore reviewed Feb 1, 2021
View reviewed changes
draft/planner_test.go Outdated Show resolved Hide resolved
@ryanmoran
Copy link
Member

The dotnet-core-runtime buildpack is now using a regular expression to evaluate the version-source matching a priority declaration: https://github.com/paketo-buildpacks/dotnet-core-runtime/blob/11b7d02648c9749d91356f3c7fa7b1419eca7242/plan_entry_resolver.go#L60-L62

Can we add support for that?

@ForestEckhardt
Copy link
Contributor Author

@ryanmoran There are some issues with doing a regular expression match. I would be interested in hearing what you would propose for the implementation.

@ryanmoran
Copy link
Member

I've taken a stab at a simple implementation that supports regular expressions: 92d1894.

The main design choice was to assume that all strings passed as the priorities are regular expressions.

@ryanmoran
Copy link
Member

@sophiewigmore maybe this implementation would be better? In this case, we are allowing strings for exact matching and regexp for fuzzier matching cases.

@sophiewigmore
Copy link
Member

@ryanmoran Oh wow, yeah. I definitely prefer that to requiring regexp only.

sophiewigmore
sophiewigmore previously approved these changes Feb 9, 2021
View reviewed changes
@ForestEckhardt
Copy link
Contributor Author

@ryanmoran @sophiewigmore LGTM

ForestEckhardt and others added 6 commits February 10, 2021 17:44
@ForestEckhardt @ryanmoran
Adds judge package
83991ed 
- This package implements a type that is meant to be a generic Buildpack
Plan entry resolves as well as a LayerType merger
@ForestEckhardt @ryanmoran
Rename judge to draft
9180567
@ForestEckhardt @ryanmoran
Changes signature of both functions on Planner
708dbc6 
- Removes built in logging for Resolve in favor of just returning a
sorted list. Also removed the bool due to confusing design.
- Removed flag types from flag merger function as that type will be
depercated soon. Now return bools.
@ForestEckhardt @ryanmoran
Update draft/planner_test.go
8a87ed1 
Co-authored-by: Sophie Wigmore <swigmore@vmware.com>
@ryanmoran
Assume all priorities are regular expressions
1ef7c16
@ryanmoran
Allows priorities to be a regex or string
b4761a4
@ryanmoran ryanmoran merged commit 3f81926 into main Feb 11, 2021
@ryanmoran ryanmoran deleted the judge branch February 11, 2021 01:48
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmoran ryanmoran ryanmoran approved these changes

@sophiewigmore sophiewigmore sophiewigmore left review comments

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ForestEckhardt @ryanmoran @sophiewigmore