Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrapper to receive github-config and dependency updates #52

Closed
fg-j opened this issue Mar 5, 2021 · 4 comments · Fixed by #53
Closed

Update bootstrapper to receive github-config and dependency updates #52

fg-j opened this issue Mar 5, 2021 · 4 comments · Fixed by #53
Assignees

Comments

@fg-j
Copy link

fg-j commented Mar 5, 2021

The bootstrapper has fallen out of date in a number of ways including

  • the version of packit, occam, etc. in the template go.mod
  • the workflows in the template .github directory

These should be resolved so buildpack authors have a seamless and up-to-date bootstrapping experience. First-time contributors likely won't have enough context to un-tangle the issues they run into caused by out-of-date setup.

@sophiewigmore
Copy link
Member

@fg-j I'm not sure that there's a way to keep the workflows up to date in the template-cnb directory, it doesn't look like GHA has a way to use workflows that aren't in a top level .github. If I understand this issue properly, the main issue was the go.mod being out of date?

@fg-j
Copy link
Author

fg-j commented Mar 15, 2021

I think the workflows and scripts being out of date was also an issue. If the repo could somehow use the github config sync action but update the files that live in template-cnb/.github/workflows instead of the .github directory, that'd be helpful. Seems like the sync action takes an arg that specifies into where to sync the desired files, so I think it'd be do-able to have template-cnb/.github/workflows and template-cnb/scripts consistently look like an up-to-date implementation buildpack.

@ryanmoran
Copy link
Member

Yes. The workspace argument can point at an arbitrary path so it can be pointed at a sub-directory within the repo.

@sophiewigmore
Copy link
Member

PRs such as #59 and #60 are now getting opened to bump versions in the go.mod.
It appears that the update-github-config GHA workflow is also scanning the workflows inside /template-cnb.
I believe this issue can be closed out now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants