Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkUnusedConstraints fails before verifyLocks fails, obscuring root cause of errors #922

Open
gatesn opened this issue Apr 21, 2022 · 0 comments

Comments

@gatesn
Copy link

gatesn commented Apr 21, 2022

What happened?

checkUnusedConstraints task was failing in CI even though it was succeeding locally.

What did you want to happen?

The root cause was that I hadn't configured the username/password for my Maven repo. This wasn't obvious from the checkUnusedConstraints failure (claiming the pin in versions.props was unused), but was obvious from the failure of verifyLocks (claiming username should not be null).

I think there should be a task dependency from checkUnusedConstraints onto verifyLocks, ensuring that the resolution succeeds before checking for unused things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant