Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[Rule Request] prefer-async #4279

Closed
Lonli-Lokli opened this issue Nov 8, 2018 · 4 comments
Closed

[Rule Request] prefer-async #4279

Lonli-Lokli opened this issue Nov 8, 2018 · 4 comments

Comments

@Lonli-Lokli
Copy link

Rule Suggestion

Warn or error the case when Promise.then() syntax is used instead of await.

instead of
promise.then(() => {do smth})

await prmise();
{do smth}

@JoshuaKGoldberg
Copy link
Contributor

Agreed, this would be a good rule. TypeScript can suggest this itself with microsoft/TypeScript#25082. Should TSLint use the TypeScript diagnostics for inference and suggestions? Is such a thing reasonably possible (#4100 / #4215)?

@JoshuaKGoldberg
Copy link
Contributor

Note: per #4534, this issue will be closed in less than a month if no PR is sent to add the rule. If you really need the rule, custom rules are always an option and can be maintained outside this repo!

@JoshuaKGoldberg
Copy link
Contributor

💀 It's time! 💀

TSLint is being deprecated and no longer accepting pull requests for new rules. See #4534. 😱

If you'd like to see this rule implemented, you have two choices:

👋 It was a pleasure open sourcing with you!

If you believe this message was posted here in error, please comment so we can re-open the issue!

@JoshuaKGoldberg
Copy link
Contributor

🤖 Beep boop! 👉 TSLint is deprecated 👈 (#4534) and you should switch to typescript-eslint! 🤖

🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋

@palantir palantir locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants