Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "convert_unicode" #707

Closed
diogobaeder opened this issue Mar 26, 2019 · 2 comments
Closed

Remove "convert_unicode" #707

diogobaeder opened this issue Mar 26, 2019 · 2 comments

Comments

@diogobaeder
Copy link

Hi,

The "convert_unicode" argument is being used in flask-sqlalchemy, however it's deprecated in SQLAlchemy:

SADeprecationWarning: The create_engine.convert_unicode parameter and corresponding dialect-level parameters are deprecated, and will be removed in a future release.  Modern DBAPIs support Python Unicode natively and this parameter is unnecessary.
    default.DefaultDialect.__init__(self, **kwargs)

So the options here should probably be an empty dict, right?: https://github.com/pallets/flask-sqlalchemy/blob/50944e77522d4aa005fc3c833b5a2042280686d3/flask_sqlalchemy/__init__.py#L558

Thanks,
Diogo

@rsyring
Copy link
Contributor

rsyring commented Mar 26, 2019

Thanks for the report. This will be resolved in #684.

@diogobaeder
Copy link
Author

Ah, cool, good to know! Thanks!

(Feel free to close the issue if it's not relevant anymore)

@rsyring rsyring closed this as completed Mar 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants