Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which servers support wsgi.input_terminated #2547

Closed
DiegoAlbertoTorres opened this issue Dec 8, 2017 · 2 comments
Closed

Document which servers support wsgi.input_terminated #2547

DiegoAlbertoTorres opened this issue Dec 8, 2017 · 2 comments

Comments

@DiegoAlbertoTorres
Copy link
Contributor

I learned from multiple issues (like https://github.com/kennethreitz/httpbin/issues/340, pallets/werkzeug#1149, #367) that Flask developers are making a push to implement wsgi.input_terminated as a way for wsgi servers and apps to support chunked requests.

However, it is extremely hard to navigate these issues and figure out what works and what does not. Is there an intention to document the support for this flag? This is a great feature, but from the user's perspective it is currently very hard to even figure out how it works. I propose at least keeping an issue alive with information on which environments will support it.

Here is what worked for me:
Flask 0.12.2 + Gunicorn 19.7.1
Flask 0.12.2 + Werkzeug 0.13

What did not work for me
Flask 0.12.2 + uWSGI 2.0.15

@davidism
Copy link
Member

davidism commented Dec 8, 2017

I think it's up to each WSGI server to document that it supports chunked encoding. It's not feasible for us to keep a list up to date in Werkzeug's docs.

Not sure how Gunicorn is working, since it doesn't set the flag yet.

@mitsuhiko
Copy link
Contributor

Going to close this for the reasons outlined above. We can't stay up to date with what other servers do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants