Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate Term & Expr in the pd.* namespace #13785

Closed
jreback opened this issue Jul 25, 2016 · 7 comments
Closed

DEPR: deprecate Term & Expr in the pd.* namespace #13785

jreback opened this issue Jul 25, 2016 · 7 comments
Labels
Deprecate Functionality to remove in pandas IO HDF5 read_hdf, HDFStore
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jul 25, 2016

This is imported via pandas.io.api. I think making a sub-class might work that has the deprecation.

This is used internally, just want to remove the external visibility (as not been necessary for quite a few releases).

@jreback jreback added IO HDF5 read_hdf, HDFStore Deprecate Functionality to remove in pandas labels Jul 25, 2016
@jreback jreback added this to the 0.19.0 milestone Jul 25, 2016
@jorisvandenbossche
Copy link
Member

Maybe unrelated, but there is also the pd.Expr in the top-level namespace, and I don't think that is used in the docs. Would that also be a candidate for deprecation as a public top-level function?

@jreback jreback changed the title DEPR: deprecate Term in the pd.* namespace DEPR: deprecate Term & Expr in the pd.* namespace Jul 25, 2016
@jreback
Copy link
Contributor Author

jreback commented Jul 25, 2016

yes both of these should be removed from the pd namespace

@jreback
Copy link
Contributor Author

jreback commented Jul 25, 2016

I think they need to have a proxy-object to provide the deprecation and then return the current object.

@jorisvandenbossche
Copy link
Member

or would a subclass work? (in pandas/init.py or in io.api.py):

class Expr(pandas.computation.expr.Expr)

    def __init__(self, *args, **kwargs):
        warnings.warn(...)
        super(Expr, self).__init__()

@jreback
Copy link
Contributor Author

jreback commented Jul 25, 2016

yes a public subclass would work (and leave the current names)

@jreback
Copy link
Contributor Author

jreback commented Jul 25, 2016

closing in favor of #13790

@jreback jreback closed this as completed Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

No branches or pull requests

2 participants