Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove total_seconds function from objToJSON.c #17340

Closed
jbrockmendel opened this issue Aug 25, 2017 · 0 comments · Fixed by #17341
Closed

Remove total_seconds function from objToJSON.c #17340

jbrockmendel opened this issue Aug 25, 2017 · 0 comments · Fixed by #17341
Labels
Clean Internals Related to non-user accessible pandas implementation
Milestone
0.21.0

Comments

@jbrockmendel
Copy link
Member

There is a legacy function total_seconds that is no longer needed. There is one usage left in _libs/src/ujson/objToJSON.c`. Someone competent in C should be able to remove it without much trouble.

See discussion in #17289.
@chris-b1 chris-b1 mentioned this issue Aug 25, 2017
Merged
3 tasks
@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Aug 26, 2017
@jreback jreback modified the milestones: Next Major Release, 0.21.0 Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

CLN: remove total_seconds compat from json chris-b1/pandas
3 participants
@jreback @jbrockmendel @gfyoung