-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge cdate_range functionality into bdate_range #17596
Comments
I would deprecate I am -0 on keeping |
FWIW the |
If we deprecate something, I would rather do |
ok let's do it as described here (cdate deprecated and merged to bdate) |
quite a bit of docs will need updating in timeseries.rst; could take opportunity to freshen those as well |
Following up on some discussion from #17554.
The main point of discussion was regarding merging the functionality of
cdate_range
intobdate_range
. This would involve adding the two additional keywords supported bycdate_range
tobdate_range
(weekmask
andholidays
), which would only be used (if provided) when a custom frequency is passed tobdate_range
.This wouldn't be terribly invasive, as
cdate_range
is only top-level on master (not 0.20.3), and there is no documentation mentioning it. Performing the merge would help keep the top-level API clean, and reduce the number ofdate_range
related functions. On the user end, the change would amount tocdate_range(...)
->bdate_range(..., freq='C')
.An alternative would be to merge both
bdate_range
andcdate_range
intodate_range
. The only difference betweenbdate_range
anddate_range
is the default value offreq
, so from a technical standpoint it wouldn't add complexity to implement compared to just mergingcdate_range
->bdate_range
.This would be a more invasive change though, as
bdate_range
currently is currently top-level, and there is some documentation mentioning it, so there'd be some additional work in terms of deprecation/doc modification. It would provide the advantage of having only onedate_range
related function. On the user end, the change would amount tocdate_range(...)
->date_range(..., freq='C')
, andbdate_range(...)
->date_range(..., freq='B')
.The current plan is to do the
cdate_range
->bdate_range
merge, but we're interested in community input.cc @jorisvandenbossche
The text was updated successfully, but these errors were encountered: