-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.apply() for core.window.Window (feature request) #19286
Comments
The direct answer to your question is here #11603 (comment) - as you may or may not be aware, there used to be set a of top level As you note, it's sort of half-implemented - only supports sum and mean. I wouldn't be opposed to having it more fully implemented under a |
Thanks, acknowledged. |
@pirius this is very simple. The implementation of a weighted window only accepts mean or sum. It should prob share code with the remainder of rolling but it doesn't. a pull request for enhancements would be accepted. |
FYI, only for |
Code Sample, a copy-pastable example if possible
Problem description
core.window.Window
does not yet provide apply functionality likecore.window.Rolling
does, hence functions other than the readily provided ones (likesum()
,mean()
, etc) cannot be applied to it.(I'm not to deep into the details, but IMHO returning different object types for just changing the window type from rectangular to some other window form seems rather unintuitive altogether. What was the reason for it being designed this way? I couldn't quickly come up with any. It leads to e.g. example 1 from above working fine as long as the
win_type
parameter is untouched - but breaks as soon aswin_type
is changed to a different-than-rectangular window, which does not semantically seem to make sense.)Expected Output
core.window.Window
should provide apply functionality, probably via.apply()
likecore.window.Rolling
, so that example 2 from above works fine too.Output of
pd.show_versions()
[paste the output of
pd.show_versions()
here below this line]INSTALLED VERSIONS
commit: None
python: 3.6.3.final.0
python-bits: 64
OS: Linux
OS-release: 4.13.0-26-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: en_US.UTF-8
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8
pandas: 0.22.0
pytest: 3.2.1
pip: 9.0.1
setuptools: 36.5.0.post20170921
Cython: 0.26.1
numpy: 1.13.3
scipy: 1.0.0
pyarrow: None
xarray: None
IPython: 6.1.0
sphinx: 1.6.3
patsy: 0.4.1
dateutil: 2.6.1
pytz: 2017.2
blosc: None
bottleneck: 1.2.1
tables: 3.4.2
numexpr: 2.6.2
feather: None
matplotlib: 2.1.0
openpyxl: 2.4.8
xlrd: 1.1.0
xlwt: 1.3.0
xlsxwriter: 1.0.2
lxml: 4.1.0
bs4: 4.6.0
html5lib: 0.999999999
sqlalchemy: 1.1.13
pymysql: None
psycopg2: None
jinja2: 2.9.6
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: None
The text was updated successfully, but these errors were encountered: