Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Clarify passing epoch timestamp to Timestamp with timezone. #20257

Closed
mroeschke opened this issue Mar 10, 2018 · 3 comments · Fixed by #25254
Closed

DOC: Clarify passing epoch timestamp to Timestamp with timezone. #20257

mroeschke opened this issue Mar 10, 2018 · 3 comments · Fixed by #25254
Labels
Docs Timezones Timezone data dtype
Milestone

Comments

@mroeschke
Copy link
Member

In [9]: int_arg = Timestamp('2010-01-01 12:00:00').value

In [10]: int_arg
Out[10]: 1262347200000000000

# With tz string
In [11]: Timestamp(int_arg, tz='US/Pacific')
Out[11]: Timestamp('2010-01-01 04:00:00-0800', tz='US/Pacific')

In [12]: Timestamp('2010-01-01 12:00:00', tz='US/Pacific') # correct
Out[12]: Timestamp('2010-01-01 12:00:00-0800', tz='US/Pacific')

# With tzinfo object
In [13]: Timestamp(int_arg, tzinfo=pytz.FixedOffset(60))
Out[13]: Timestamp('2010-01-01 13:00:00+0100', tz='pytz.FixedOffset(60)')

In [14]: Timestamp('2010-01-01 12:00:00', tzinfo=pytz.FixedOffset(60)) # correct
Out[14]: Timestamp('2010-01-01 12:00:00+0100', tz='pytz.FixedOffset(60)')

Output of pd.show_versions()

INSTALLED VERSIONS

commit: be4ad6fb532e2892bacc5896d673c8769cd0035a
python: 3.6.4.final.0
python-bits: 64
OS: Linux
OS-release: 4.4.0-43-Microsoft
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8

pandas: 0.23.0.dev0+483.gbe4ad6f.dirty
pytest: 3.3.2
pip: 9.0.1
setuptools: 38.4.0
Cython: 0.27.3
numpy: 1.14.0
scipy: 1.0.0
pyarrow: 0.8.0
xarray: 0.10.0
IPython: 6.2.1
sphinx: 1.6.6
patsy: 0.5.0
dateutil: 2.6.1
pytz: 2017.3
blosc: None
bottleneck: 1.2.1
tables: 3.4.2
numexpr: 2.6.4
feather: 0.4.0
matplotlib: 2.1.2
openpyxl: 2.4.10
xlrd: 1.1.0
xlwt: 1.3.0
xlsxwriter: 1.0.2
lxml: 4.1.1
bs4: 4.6.0
html5lib: 1.0.1
sqlalchemy: 1.2.1
pymysql: 0.7.11.None
psycopg2: None
jinja2: 2.10
s3fs: 0.1.2
fastparquet: 0.1.4
pandas_gbq: None
pandas_datareader: None

@jreback
Copy link
Contributor

jreback commented Mar 10, 2018

we have an issue about this, though can't seem to find it ATM. yeah this is a bug. if you'd have a look thru the issues would be great (and of course a PR to fix!)

@jreback jreback added this to the Next Major Release milestone Mar 10, 2018
@mroeschke
Copy link
Member Author

Actually, I think this behavior is expected. It only makes sense for a passed int or float to be an epoch timestamp (from UTC), so the localization makes sense. Maybe this can be clarified in the docs (timeseries.rst).

@mroeschke mroeschke changed the title Timestamp constructed with int and timezone information localizes to UTC first. DOC: Clarify passing epoch timestamp to Timestamp with timezone. Mar 11, 2018
@jreback
Copy link
Contributor

jreback commented Mar 12, 2018

ok that sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants