-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Extract methods from TestXMySQL and TestXSQLite and remove #20536
Comments
It's no longer deprecated, but actually removed (for mysql writing) or accepted (for sqlite, and in practice also for reading query's)
Yeah, IIRC those tests were old tests from before the sqlalchemy refactor, and kept for "we should actually clean up the tests (go through them, and keep the useful bits in case it is not yet covered in the other tests), but that is some work, so just leave them there for now" reasons |
Gotcha, so the TODO here is to pick out the interesting tests, and move them to the _TestMySQLAlchemy class?: |
Yep (but it might be there is actually nothing interesting) |
And the same is true actually for |
One potential strategy for discovering which lines are tested in just TestX*:
dif the two coverage reports (not sure if there's a tool to do this, or if you would do it manually). |
I think the precursor ADBC work to refactor the sql tests addressed this so closing |
I haven't looked too closely, but in https://github.com/pandas-dev/pandas/pull/13611/files the
TestXMySql
tests were unconditionally skipped.IIUC, these are the test using a DBAPI2
Connection
object, which is deprecated? We should remove these tests if they aren't being run.The text was updated successfully, but these errors were encountered: