Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: _cython_table bug (part 2) #22156

Closed
topper-123 opened this issue Aug 1, 2018 · 2 comments
Closed

BUG: _cython_table bug (part 2) #22156

topper-123 opened this issue Aug 1, 2018 · 2 comments
Labels
Bug Internals Related to non-user accessible pandas implementation
Milestone

Comments

@topper-123
Copy link
Contributor

topper-123 commented Aug 1, 2018

#22110 was supposed to fix a bug introduced by #21224, where xdist fails because fixtures have random order because dicts too do have random order for Python < 3.6.

If appears that this is not fixed after all, as I got the xdist bug in #21699 too. The issue is that it is not even enough to sort by function name, as several function have the same name ( sum has the same name as np.sum and so on).

I can make a fix where conftest._cython_table is ordered manually for the short term, but longer term it seems to me the chosen approach is a bit too messy. I'm however going on vacation tomorrow, so won't be able to work on this for a time, but I could put in the short term fix tonight and fix it long term when I'm back.

@gfyoung gfyoung added Bug Internals Related to non-user accessible pandas implementation labels Aug 3, 2018
@gfyoung
Copy link
Member

gfyoung commented Aug 3, 2018

Let's get the short term fix down, and we can evaluate.

(and enjoy your vacation!)

@topper-123
Copy link
Contributor Author

This has been fixed in #22157.

@gfyoung gfyoung added this to the 0.24.0 milestone Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

No branches or pull requests

2 participants