Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test_sql.py #22624

Closed
alimcmaster1 opened this issue Sep 6, 2018 · 1 comment
Closed

Refactor test_sql.py #22624

alimcmaster1 opened this issue Sep 6, 2018 · 1 comment
Labels
Clean Testing pandas testing functions or related to the test suite

Comments

@alimcmaster1
Copy link
Member

Off the back of discussion in this PR we should consider refactoring test_sql.py to use just PyTest Fixtures opposed to fixures and the old xunit style setup.

Thanks,

Alistair
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Clean labels Sep 6, 2018
@alimcmaster1 alimcmaster1 mentioned this issue Sep 6, 2018
Merged
@vrajmohan vrajmohan mentioned this issue Jan 31, 2019
Closed
2 tasks
@alimcmaster1 alimcmaster1 mentioned this issue Feb 17, 2019
Merged
2 tasks
@tnwei
Copy link
Contributor

tnwei commented Oct 23, 2020

Looks like the last PR resolves this issue, suggest to close

@jreback jreback closed this as completed Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jreback @mroeschke @tnwei @alimcmaster1