Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: commented-out code in _libs/sparse.pyx #23371

Closed
jbrockmendel opened this issue Oct 27, 2018 · 3 comments
Closed

CLN: commented-out code in _libs/sparse.pyx #23371

jbrockmendel opened this issue Oct 27, 2018 · 3 comments
Labels
Clean Internals Related to non-user accessible pandas implementation Sparse Sparse Data Type

Comments

@jbrockmendel
Copy link
Member

reindex_block, SparseCruncher, and (related) reindex_integer
@jbrockmendel
Copy link
Member Author

BlockIntersection

get_reindexer appears unused

@gfyoung gfyoung added Internals Related to non-user accessible pandas implementation Sparse Sparse Data Type Clean labels Oct 27, 2018
@gfyoung
Copy link
Member

gfyoung commented Oct 27, 2018

I'm all for removing commented-out code, since if there was a use for it, it would have been commented-in already awhile ago.

cc @jreback

@jbrockmendel jbrockmendel mentioned this issue Nov 8, 2018
Merged
@jbrockmendel
Copy link
Member Author

Closed by #23583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation Sparse Sparse Data Type
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @gfyoung