-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Reorganization of the documentation #24499
Comments
+1 on top level section for the different pages. For reference, here's scikit-learn's documentation structure which I think is very concise and similar to what you're proposing https://scikit-learn.org/stable/documentation.html |
This is actually a duplicate of #6000 :-) But it's more or less the same. I will try to take a closer look tomorrow. Quick feedback:
|
Also, I know it will be annoying to keep those PRs open for a while (and keeping up to date with changes in master), so it might be preferred to merge them rather quickly. But maybe we should have a chat about how to move forward with the whole doc revamp (both content, theme, integration with website, etc)? |
Not sure about 0.24, you'll know better. We're already changing the links of all the api/ since Reorganizing the current pages should be quite fast, there are almost PRs for everything, except few pages that we'll require some discussion. But some changes will surely happen in the future, as it'll take much longer to split pages, and fine tune the structure. I'd say for what we discussed during the sprint, we're all happy with having few top level sections (user guide, development, whatsnew...), and also with the theme change. My opinion is that we should implement those, and then it'll be easier to discuss about the more "advanced" things like the home page, the navigation, the integration with the website... We tried twice to work on a one-shot documentation migration, and we failed, I think making the changes with small PRs is working much better. I'm flexible on the |
I'd like to help with this one if I can. I'm a regular pandas user, but I have not contributed on github much and and would need some guidance. |
@mbirdi can you better look at issues tagged as "good first issue". This requires discussion, and is not the best for a first time contributor. |
@datapythonista Thank you! I'll look for that "first issue" tag. |
Yeah, I certainly agree that some more content would be nice in the getting started section (shorter version of those basics, or a expanded version of the 10min). |
What makes sense for me is a multipart tutorial, I'd say a 3 part, something like But I'd use a real dataset and not arbitrary data where possible, give an overview (without much details) of everything that pandas does, and following a logical sequence. But that discussion is probably for later, this won't happen during the reorganization I'd say, it's a lot of work. |
I use the online docs quite a bit and am wondering what is the rationale for the new format of the Table of Contents. The new format nicely compresses the main TOC tree into reasonable starting groups, however it detrimentally removes a third level of the tree that is very useful for quickly identifying and navigating to subsections of individual User Guide main topics. For example the new format now only has
Can't the third level be added as an expansion of the tree that occurs upon click? This would allow the new compact organization to be maintained. Thanks for all the work being done to maintain and improve this great tool. |
Can you open a new issue with your proposal (screenshots on where you'd like to expand/add those toc would be useful). This is still work in progress, and we're working on improving the navigation, but using sphinx is not trivial. |
What I had in mind is just to add back the additional level that was previously present. For example: User Guide now expands to reveal:
Clicking on MultiIndex/ Advanced Indexing should show as previously
|
@datapythonista I think @neili02 is pointing out what I mentioned this weekend as well: for some reason the TOC now only shows two levels, instead of 3, which has the consequence you don't see anything of TOC from the page you are on. Looking at it, I think this is due to the change here 013ae3d where we changed maxdepth from 4 to 2 for the main index.rst. So it seems this toctree depth is what determines the depth, whatever depth you put on eg |
Commented on the PR. If the toctree in the index is affecting that, that's a bug from sphinx. I mentioned in the PR how I think could be fixed. |
It appears our current https://pandas.pydata.org/pandas-docs/stable/index.html page more-or-less fits the hierarchy initially proposed. I think from that this issue can be closed, but if certain sections still should be moved we can open new issues for them individually. |
The documentation currently has almost all the pages in the same level. Making it difficult to navigate.
Having few top-level sections that group the pages, and some hierarchy would make things simpler to find. Here there is a prototype of how having few top-level sections could look like: https://pandas-dev.github.io/pandas-sphinx-theme/pr-datapythonista_base/
Those are the pages we currently have:
An initial proposal of organization is:
@pandas-dev/pandas-core thoughts?
The text was updated successfully, but these errors were encountered: