Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test_constructors.py::TestSeriesConstructors::test_constructor_dtype_datetime64 #24827

Closed
simonjayhawkins opened this issue Jan 18, 2019 · 3 comments · Fixed by #24868
Closed
Labels
Datetime Datetime data dtype good first issue Testing pandas testing functions or related to the test suite

Comments

@simonjayhawkins
Copy link
Member

xref #24812 (comment). follow-up PR required.

@charlesdong1991
Copy link
Member

charlesdong1991 commented Jan 18, 2019

should it then raise a TypeError?

@gfyoung
Copy link
Member

gfyoung commented Jan 20, 2019

@charlesdong1991 : It looks the correct error is raised, but the message is not quite right.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Datetime Datetime data dtype good first issue labels Jan 20, 2019
@charlesdong1991
Copy link
Member

charlesdong1991 commented Jan 20, 2019

yeah, will take a closer look @gfyoung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants