Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation error type PR04 and check in CI #25105

Closed
2 tasks
kynan opened this issue Feb 3, 2019 · 4 comments · Fixed by #25157
Closed
2 tasks

Fix validation error type PR04 and check in CI #25105

kynan opened this issue Feb 3, 2019 · 4 comments · Fixed by #25157

Comments

@kynan
Copy link
Contributor

kynan commented Feb 3, 2019

Problem description

In order to have a continuous check by the CI on validation error PR04 (Parameter "{param_name}" has no type), tackling them from the current code base enables the addition to the CI for automated testing in the future.

PR04 has just 12 occurrences (see overview of the errors):

method file file_line github_link
pandas.core.resample.Resampler.std pandas/core/resample.py 797.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/resample.py#L797
pandas.Grouper pandas/core/groupby/grouper.py 30.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/groupby/grouper.py#L30
pandas.core.groupby.GroupBy.rank pandas/core/groupby/groupby.py 1811.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/groupby/groupby.py#L1811
pandas.core.groupby.DataFrameGroupBy.rank pandas/core/groupby/groupby.py 1811.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/groupby/groupby.py#L1811
pandas.Panel.apply pandas/core/panel.py 1000.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/panel.py#L1000
pandas.Panel.transpose pandas/core/panel.py 1270.0 https://github.com/pandas-dev/pandas/blob/master/pandas/core/panel.py#L1270
pandas.Timedelta None NaN https://github.com/pandas-dev/pandas/blob/master/None#LNone
pandas.Timedelta.max None NaN https://github.com/pandas-dev/pandas/blob/master/None#LNone
pandas.Timedelta.min None NaN https://github.com/pandas-dev/pandas/blob/master/None#LNone
pandas.factorize pandas/util/_decorators.py 559.0 https://github.com/pandas-dev/pandas/blob/master/pandas/util/_decorators.py#L559
pandas.read_parquet pandas/io/parquet.py 255.0 https://github.com/pandas-dev/pandas/blob/master/pandas/io/parquet.py#L255
pandas.io.formats.style.Styler.render pandas/io/formats/style.py 421.0 https://github.com/pandas-dev/pandas/blob/master/pandas/io/formats/style.py#L421

Todo:

  • get rid of the errors in the code base
  • update the code_check.sh script to take into account the PR04 type of errors
@kynan kynan changed the title Excluding validation error type PR04 from code base Fix validation error type PR04 and check in CI Feb 3, 2019
@jorisvandenbossche jorisvandenbossche added this to the Contributions Welcome milestone Feb 3, 2019
@mwoss
Copy link
Contributor

mwoss commented Feb 3, 2019

Hi. May I work on this issue? :)

@mwoss
Copy link
Contributor

mwoss commented Feb 4, 2019

I have no idea how to fix Timedelta docs. I cannot locate file with that class.

@thoo
Copy link
Contributor

thoo commented Feb 4, 2019

@mwoss Timedelta docs might be there: pandas/_libs/tslibs/timedeltas.pyx . You need to rebuild the extension. python setup.py build_ext --inplace -j 4

@mwoss
Copy link
Contributor

mwoss commented Feb 4, 2019

@thoo Thanks you a lot :) I will look at that file.

@mwoss mwoss mentioned this issue Feb 5, 2019
4 tasks
@jreback jreback modified the milestones: Contributions Welcome, 0.25.0 Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants