Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try supporting Python 3.6.0 #30794

Closed
TomAugspurger opened this issue Jan 7, 2020 · 3 comments
Closed

Try supporting Python 3.6.0 #30794

TomAugspurger opened this issue Jan 7, 2020 · 3 comments
Labels
Compat pandas objects compatability with Numpy or Python functions

Comments

@TomAugspurger
Copy link
Contributor

In #29212, we bumped the minimum Python to 3.6.1. @datapythonista mentioned an issue with 3.6.0 at #29212 (comment)

Seems like Python 3.6 has something (I guess a bug) causing the error TypeError: only integer scalar arrays can be converted to a scalar index when converting strings to bytes in some of our cases.

I vaguely recall a few issues with 0.25.x requiring a point release of python 3.5. We should see if we can support 3.6.0 to save some headaches down the road.

@TomAugspurger TomAugspurger added this to the 1.0 milestone Jan 7, 2020
@TomAugspurger TomAugspurger added the Compat pandas objects compatability with Numpy or Python functions label Jan 7, 2020
@jreback
Copy link
Contributor

jreback commented Jan 7, 2020

really? why the effort here? this seems not worth it.

@WillAyd
Copy link
Member

WillAyd commented Jan 7, 2020

IIRC I think bumping numpy to 1.15 might have solved the same issue we were trying to solve in bumping to 3.6.1 so maybe it does just work now, but agreed with Jeff that at the same time it's not worth a lot of effort

For 0.25 we required 3.5.2 as a min and I don't recall coming across any issues or complaints from that

@TomAugspurger
Copy link
Contributor Author

For 0.25 we required 3.5.2 as a min and I don't recall coming across any issues or complaints from that

I recall a few (didn't find any in a search) though I think that was in part due to some ubuntu version having 3.5.0 by default.

Anyway, we use 3.6.1+ features like typing.ChainMap, so not a high enough priority.

@TomAugspurger TomAugspurger modified the milestones: 1.0, No action Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants