Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: jedi v0.18.0 breaks a number of ipython test_tab_complete_warning tests #38703

Closed
2 of 3 tasks
moink opened this issue Dec 26, 2020 · 5 comments · Fixed by #42832
Closed
2 of 3 tasks

CI: jedi v0.18.0 breaks a number of ipython test_tab_complete_warning tests #38703

moink opened this issue Dec 26, 2020 · 5 comments · Fixed by #42832
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions
Milestone

Comments

@moink
Copy link
Member

moink commented Dec 26, 2020

It looks like jedi version 0.18.0 was released yesterday and broke the following tests:

FAILED pandas/tests/arrays/categorical/test_warnings.py::TestCategoricalWarnings::test_tab_complete_warning
FAILED pandas/tests/frame/test_api.py::TestDataFrameMisc::test_tab_complete_warning[DataFrame]
FAILED pandas/tests/frame/test_api.py::TestDataFrameMisc::test_tab_complete_warning[Series]
FAILED pandas/tests/indexes/test_base.py::TestIndex::test_tab_complete_warning
FAILED pandas/tests/resample/test_resampler_grouper.py::test_tab_complete_ipython6_warning

in the Linux py38_Locale pipeline only.

I have looked into it and it seems that it is caused by this commit which is part of version 0.18.0 of Jedi
davidhalter/jedi@abb2250

Ipython has a commit that I believe will fix the error:
ipython/ipython@dcd9dc9
but it's slated for inclusion in version 8.0 of ipython:
ipython/ipython#11816
(version 7.19.0 is the most recent release, on 2020-10-30)

It's causing failures in all PRs that were submitted today (2020-12-26) starting with #38696

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.


@moink moink added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 26, 2020
@moink moink changed the title BUG: jedi v0.18.0 breaks a number of ipython completion tests BUG: jedi v0.18.0 breaks a number of ipython test_tab_complete_warning tests Dec 26, 2020
@simonjayhawkins simonjayhawkins added CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 26, 2020
@moink moink changed the title BUG: jedi v0.18.0 breaks a number of ipython test_tab_complete_warning tests CI: jedi v0.18.0 breaks a number of ipython test_tab_complete_warning tests Dec 26, 2020
@jreback
Copy link
Contributor

jreback commented Dec 26, 2020

ok let's just pin for now (and leave this issue open to revert when it's fixed)

love for a PR

@Decodetalkers
Copy link

Yes ,I also find this problem

@Decodetalkers
Copy link

After remove the jedi, and it become normal...haha,

no, when use V0.17,I can also cannot use autocomplete

@Carreau
Copy link
Contributor

Carreau commented Feb 1, 2021

I've just release IPython 7.20; does that fixes it ?

@jreback
Copy link
Contributor

jreback commented Feb 2, 2021

cc @simonjayhawkins xref the ipython tab complete tests on 1.2.2 that are failing (as we skip for jedi <= 0.17)

@lithomas1 lithomas1 mentioned this issue Jul 31, 2021
4 tasks
@simonjayhawkins simonjayhawkins added this to the 1.3.2 milestone Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants