Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Make network decorator impose a skipTest catching URLErrors #3910

Closed
jtratner opened this issue Jun 15, 2013 · 5 comments · Fixed by #3914
Closed

TST: Make network decorator impose a skipTest catching URLErrors #3910

jtratner opened this issue Jun 15, 2013 · 5 comments · Fixed by #3914
Milestone

Comments

@jtratner
Copy link
Contributor

Basically, do this in the network decorator:

    @wraps
    def network_wrapper(*args, **kwargs):
        try:
            return t(*args, **kwargs)
        except URLError:
            raise nose.skipTest

Working on it right now

@cpcloud
Copy link
Member

cpcloud commented Jun 15, 2013

@jtratner b4 u spend time on this maybe see #3822

@jtratner
Copy link
Contributor Author

@cpcloud yeah, but it really needs to be opt-out rather than opt-in

@jreback
Copy link
Contributor

jreback commented Jun 20, 2013

@cpcloud close this? (as @jtratner put all of the stuff in)

@cpcloud
Copy link
Member

cpcloud commented Jun 20, 2013

this will be closed by #3914

@jreback
Copy link
Contributor

jreback commented Jun 20, 2013

great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants