Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: DataFrame.rank & Series.rank results are inconsistent #43310

Closed
2 of 3 tasks
galipremsagar opened this issue Aug 30, 2021 · 5 comments
Closed
2 of 3 tasks

BUG: DataFrame.rank & Series.rank results are inconsistent #43310

galipremsagar opened this issue Aug 30, 2021 · 5 comments
Labels
Duplicate Report Duplicate issue or pull request

Comments

@galipremsagar
Copy link

galipremsagar commented Aug 30, 2021

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.


Note: Please read this guide detailing how to provide the necessary information for us to reproduce your bug.

Code Sample, a copy-pastable example

>>> import pandas as pd
>>> import numpy as np
>>> values = [-np.inf, 0, np.inf, np.nan, 2, np.nan]         
>>> s = pd.Series(values)
>>> s
0   -inf
1    0.0
2    inf
3    NaN
4    2.0
5    NaN
dtype: float64
>>> kwargs = {'method': 'dense', 'na_option': 'bottom', 'ascending': False, 'pct': False, 'numeric_only': False}
>>> s.rank(**kwargs)
0    4.0
1    3.0
2    1.0
3    5.0
4    2.0
5    5.0
dtype: float64
>>> pd.DataFrame({'a':s}).rank(**kwargs)
     a
0  4.0
1  3.0
2  1.0
3  4.0
4  2.0
5  4.0
>>> 

Problem description

The results being returned by Series.rank & DataFrame.rank seem to be inconsistent.

Expected Output

Output of DataFrame.rank must be returned correctly(as is being done by Series.rank)

Output of pd.show_versions()

INSTALLED VERSIONS

commit : 5f648bf
python : 3.8.10.final.0
python-bits : 64
OS : Linux
OS-release : 5.11.0-27-generic
Version : #29~20.04.1-Ubuntu SMP Wed Aug 11 15:58:17 UTC 2021
machine : x86_64
processor : x86_64
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8

pandas : 1.3.2
numpy : 1.21.2
pytz : 2021.1
dateutil : 2.8.2
pip : 21.2.4
setuptools : 57.4.0
Cython : 0.29.24
pytest : 6.2.4
hypothesis : 6.17.2
sphinx : 4.1.2
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : 3.0.1
IPython : 7.27.0
pandas_datareader: None
bs4 : 4.9.3
bottleneck : None
fsspec : 2021.07.0
fastparquet : None
gcsfs : None
matplotlib : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : 5.0.0
pyxlsb : None
s3fs : None
scipy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
xlwt : None
numba : 0.53.1

@galipremsagar galipremsagar added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 30, 2021
@phofl
Copy link
Member

phofl commented Aug 30, 2021

Duplicate of #32593

@phofl phofl marked this as a duplicate of #32593 Aug 30, 2021
@phofl phofl closed this as completed Aug 30, 2021
@phofl phofl added Duplicate Report Duplicate issue or pull request and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 30, 2021
@galipremsagar
Copy link
Author

@phofl This issues seems to be occurring in the most recent version of pandas as posted in the versions tab.

@phofl
Copy link
Member

phofl commented Aug 30, 2021

This works on master

@phofl
Copy link
Member

phofl commented Aug 30, 2021

But you are correct, this was fixed by #41931

@galipremsagar
Copy link
Author

Thanks @phofl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Report Duplicate issue or pull request
Projects
None yet
Development

No branches or pull requests

2 participants