Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: BinGrouper indices #52468

Closed
rhshadrach opened this issue Apr 5, 2023 · 0 comments · Fixed by #54544
Closed

REF: BinGrouper indices #52468

rhshadrach opened this issue Apr 5, 2023 · 0 comments · Fixed by #54544
Labels
Groupby Refactor Internal refactoring of code
Milestone
2.2

Comments

@rhshadrach
Copy link
Member

Ref: #51414 (comment)

In #51414, BinGrouper.__iter__ was changed because the indices in BinGrouper did not behave in the same way that they do for BaseGrouper. I'm guessing (but not sure) it would be better to refactor BinGrouper.indices to better align with those in BaseGrouper. Further investigations in this regard are welcome.
@rhshadrach rhshadrach added Refactor Internal refactoring of code Groupby labels Apr 5, 2023
@taytzehao taytzehao mentioned this issue Aug 14, 2023
Merged
2 tasks
@rhshadrach rhshadrach added this to the 2.2 milestone Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Groupby Refactor Internal refactoring of code
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

refactor grouper __iter__ taytzehao/pandas
1 participant
@rhshadrach