Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Implement external error raised helper function. #31130

Merged
merged 15 commits into from
Feb 7, 2020
Merged

TST: Implement external error raised helper function. #31130

merged 15 commits into from
Feb 7, 2020

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Jan 19, 2020 •
edited
Loading

Opened PR for what @gfyoung wrote here

MomIsBestFriend added 3 commits January 19, 2020 03:51
Implemented "external_error_raised"
5291152 
@gfyoung wrote this function here
pandas-dev#30999 (comment)
so we can ignore error messages without breaking fututre CI tests of
bare pytest raises calls
Added tests
18f1d7b
Fixed small mistakes
9d53933
@ShaharNaveh ShaharNaveh mentioned this pull request Jan 19, 2020
Merged
5 tasks
@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Enhancement labels Jan 19, 2020
gfyoung
gfyoung reviewed Jan 19, 2020
View reviewed changes
pandas/_testing.py Outdated Show resolved Hide resolved
@ShaharNaveh
Copy link
Member Author

Restarting the tests, as it failed to fetch a URL.

@ShaharNaveh ShaharNaveh reopened this Jan 19, 2020
MomIsBestFriend added 7 commits January 20, 2020 23:57
@ShaharNaveh
Copy link
Member Author

gentle ping @gfyoung

@gfyoung gfyoung merged commit 4b142ef into pandas-dev:master Feb 7, 2020
@gfyoung gfyoung added this to the 1.1 milestone Feb 7, 2020
@gfyoung
Copy link
Member

gfyoung commented Feb 7, 2020

Sorry for the delay @MomIsBestFriend! Thanks for the work!

@ShaharNaveh
Copy link
Member Author

@gfyoung Thank you, you are the one who wrote it ;)

@ShaharNaveh ShaharNaveh mentioned this pull request Feb 7, 2020
Closed
5 tasks
@ShaharNaveh ShaharNaveh deleted the TST-implement-external-error-raised branch February 14, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Enhancement Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaharNaveh @gfyoung