Skip to content

Commit

Permalink
Fixed pascal casing of "SDT"
Browse files Browse the repository at this point in the history
  • Loading branch information
davidnmbond committed Dec 7, 2023
1 parent 387cfd7 commit 288eb97
Show file tree
Hide file tree
Showing 12 changed files with 63 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ await LogicMonitorClient
public async Task AddAndDeleteAResourceGroupSdt()
{
const string initialComment = "LogicMonitor.Api unit tests - AddAndDeleteAResourceGroupSdt initial comment";
var resourceGroupId = SDTResourceGroupId;
var resourceGroupId = SdtResourceGroupId;
var sdtCreationDto = new ResourceGroupScheduledDownTimeCreationDto(resourceGroupId)
{
Comment = initialComment,
Expand Down
4 changes: 2 additions & 2 deletions LogicMonitor.Api.Test/TestPortalConfig.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ internal TestPortalConfig(ILogger logger)
WindowsDeviceLargeDeviceDataSourceId = int.Parse(Configuration["Config:WindowsDeviceLargeDeviceDataSourceId"] ?? "0", CultureInfo.InvariantCulture);
ServiceDeviceId = int.Parse(Configuration["Config:ServiceDeviceId"] ?? "0", CultureInfo.InvariantCulture);
CollectorId = int.Parse(Configuration["Config:CollectorId"] ?? "0", CultureInfo.InvariantCulture);
SDTResourceGroupId = int.Parse(Configuration["Config:SDTResourceGroupId"] ?? "0", CultureInfo.InvariantCulture);
SdtResourceGroupId = int.Parse(Configuration["Config:SDTResourceGroupId"] ?? "0", CultureInfo.InvariantCulture);
TestDashboardId = int.Parse(Configuration["Config:TestDashboardId"] ?? "0", CultureInfo.InvariantCulture);
WebsiteGroupFullPath = Configuration["Config:WebsiteGroupFullPath"] ?? "";
DeviceGroupFullPath = Configuration["Config:DeviceGroupFullPath"] ?? "";
Expand Down Expand Up @@ -78,7 +78,7 @@ internal TestPortalConfig(ILogger logger)

internal int CollectorId { get; }

public int SDTResourceGroupId { get; }
public int SdtResourceGroupId { get; }

public string AlertRuleName { get; }

Expand Down
6 changes: 3 additions & 3 deletions LogicMonitor.Api.Test/TestWithOutput.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public abstract class TestWithOutput

protected int WindowsDeviceId { get; }

protected int SDTResourceGroupId { get; }
protected int SdtResourceGroupId { get; }

protected int WindowsDeviceLargeDeviceDataSourceId { get; }

Expand All @@ -44,12 +44,12 @@ protected TestWithOutput(ITestOutputHelper iTestOutputHelper)
WindowsDeviceLargeDeviceDataSourceId = testPortalConfig.WindowsDeviceLargeDeviceDataSourceId;
ServiceDeviceId = testPortalConfig.ServiceDeviceId;
NetflowDeviceId = testPortalConfig.NetflowDeviceId;
SDTResourceGroupId = testPortalConfig.SDTResourceGroupId;
SdtResourceGroupId = testPortalConfig.SdtResourceGroupId;
TestDashboardId = testPortalConfig.TestDashboardId;
DeviceGroupFullPath = testPortalConfig.DeviceGroupFullPath;
WebsiteGroupFullPath = testPortalConfig.WebsiteGroupFullPath;
ResourceGroupFullPath = testPortalConfig.ResourceGroupFullPath;
SDTResourceGroupId = testPortalConfig.SDTResourceGroupId;
SdtResourceGroupId = testPortalConfig.SdtResourceGroupId;
WebsiteName = testPortalConfig.WebsiteName;
SnmpDeviceId = testPortalConfig.SnmpDeviceId;
AllWidgetsDashboardId = testPortalConfig.AllWidgetsDashboardId;
Expand Down
6 changes: 3 additions & 3 deletions LogicMonitor.Api.Test/Websites/WebsiteTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ await LogicMonitorClient
ParentId = "1",
Properties =
[
new EntityProperty {Name = "name", Value = "value"}
new EntityProperty { Name = "name", Value = "value" }
]
//TestLocation = new TestLocation { All = true, SmgIds = new List<int> { 1, 2, 4, 3, 5, 6 } }
}, default).ConfigureAwait(true);
Expand Down Expand Up @@ -293,14 +293,14 @@ await LogicMonitorClient
}

[Fact]
public async Task GetWebsiteSDTs()
public async Task GetWebsiteSdts()
{
var websiteList = await LogicMonitorClient
.GetAllAsync<Website>(default)
.ConfigureAwait(true);

var sdts = await LogicMonitorClient
.GetWebsiteSDTListAsync(websiteList[0].Id, new Filter<ScheduledDownTime>(), default)
.GetWebsiteSdtListAsync(websiteList[0].Id, new Filter<ScheduledDownTime>(), default)
.ConfigureAwait(true);
sdts.Should().NotBeNull();
}
Expand Down
10 changes: 5 additions & 5 deletions LogicMonitor.Api/Dashboards/NOCWidgetDataItem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class NOCWidgetDataItem
/// Whether this is in scheduled downtime
/// </summary>
[DataMember(Name = "inSDT")]
public bool InSDT { get; set; }
public bool InSdt { get; set; }

/// <summary>
/// The type of the widget data item
Expand Down Expand Up @@ -79,13 +79,13 @@ public class NOCWidgetDataItem
/// Number in scheduled downtime error alerts
/// </summary>
[DataMember(Name = "inSDTErrorAlert")]
public int InSDTErrorAlert { get; set; }
public int InSdtErrorAlert { get; set; }

/// <summary>
/// Number of in scheduled downtime and confirmed error alerts
/// </summary>
[DataMember(Name = "inSDTAndConfirmedErrorAlert")]
public int InSDTAndConfirmedErrorAlert { get; set; }
public int InSdtAndConfirmedErrorAlert { get; set; }

/// <summary>
/// Number of error alerts
Expand All @@ -103,13 +103,13 @@ public class NOCWidgetDataItem
/// Number in scheduled downtime and critical alerts
/// </summary>
[DataMember(Name = "inSDTCriticalAlert")]
public int InSDTCriticalAlert { get; set; }
public int InSdtCriticalAlert { get; set; }

/// <summary>
/// Number in scheduled downtime and confirmed critical alerts
/// </summary>
[DataMember(Name = "inSDTAndConfirmedCriticalAlert")]
public int InSDTAndConfirmedCriticalAlert { get; set; }
public int InSdtAndConfirmedCriticalAlert { get; set; }

/// <summary>
/// Number of critical alerts
Expand Down
2 changes: 1 addition & 1 deletion LogicMonitor.Api/LogicMonitorClient_Websites.cs
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ await Task.WhenAll(alertFilterList.Select(async individualAlertFilter =>
/// <summary>
/// get a list of SDTs for a website
/// </summary>
public async Task<Page<ScheduledDownTime>> GetWebsiteSDTListAsync(
public async Task<Page<ScheduledDownTime>> GetWebsiteSdtListAsync(
int websiteId,
Filter<ScheduledDownTime> filter,
CancellationToken cancellationToken)
Expand Down
2 changes: 1 addition & 1 deletion LogicMonitor.Api/Reports/SlaReportMetric.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ public class SlaReportMetric
/// The exclusion SDT type
/// </summary>
[DataMember(Name = "exclusionSDTType")]
public string ExclusionSDTType { get; set; } = string.Empty;
public string ExclusionSdtType { get; set; } = string.Empty;
}
2 changes: 1 addition & 1 deletion LogicMonitor.Api/Reports/WebsiteOverviewReport.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class WebsiteOverviewReport : DateRangeReport
/// Whether to exclude SDT
/// </summary>
[DataMember(Name = "excludeSDT")]
public bool ExcludeSDT { get; set; }
public bool ExcludeSdt { get; set; }

/// <summary>
/// Whether to exclude services with 100% availability
Expand Down
2 changes: 1 addition & 1 deletion LogicMonitor.Api/Reports/WebsiteSlaReportMetric.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ public class WebsiteSlaReportMetric
/// Whether to exclude alerts occurring in SDT
/// </summary>
[DataMember(Name = "excludeSDT")]
public bool ExcludeSDT { get; set; }
public bool ExcludeSdt { get; set; }
}
30 changes: 30 additions & 0 deletions LogicMonitor.Api/Settings/HttpIntegration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,36 @@ public class HttpIntegration : Integration
[DataMember(Name = "ackOAuthVersion")]
public string? AckOAuthVersion { get; set; } = string.Empty;

/// <summary>
/// The ACK OAuth grant type
/// </summary>
[DataMember(Name = "ackOAuthGrantType")]
public string? AckOAuthGrantType { get; set; } = string.Empty;

/// <summary>
/// The ACK OAuth access token Url
/// </summary>
[DataMember(Name = "ackOAuthAccessTokenUrl")]
public string? AckOAuthAccessTokenUrl { get; set; } = string.Empty;

/// <summary>
/// The ACK OAuth client id
/// </summary>
[DataMember(Name = "ackOAuthClientId")]
public string? AckOAuthClientId { get; set; } = string.Empty;

/// <summary>
/// The ACK OAuth client secret
/// </summary>
[DataMember(Name = "ackOAuthClientSecret")]
public string? AckOAuthClientSecret { get; set; } = string.Empty;

/// <summary>
/// The ACK OAuth scope
/// </summary>
[DataMember(Name = "ackOAuthScope")]
public string? AckOAuthScope { get; set; } = string.Empty;

/// <summary>
/// The OAuth version
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions LogicMonitor.Api/Topologies/Topology.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ public class Topology : NamedItem, IHasEndpoint
[DataMember(Name = "views")]
public List<TopologyView> Views { get; set; } = [];

/// <summary>
/// The connections
/// </summary>
[DataMember(Name = "connections")]
public List<TopologyConnection> Connection { get; set; } = [];

/// <summary>
/// The REST API endpoint
/// </summary>
Expand Down
9 changes: 9 additions & 0 deletions LogicMonitor.Api/Topologies/TopologyConnection.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
namespace LogicMonitor.Api.Topologies;

/// <summary>
/// A Topology connection
/// </summary>
[DataContract]
public class TopologyConnection
{
}

0 comments on commit 288eb97

Please sign in to comment.