Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for cross-platform remote execution (i.e. from OSX to Linux) #11148

Closed
stuhood opened this issue Nov 12, 2020 · 3 comments
Closed

Allow for cross-platform remote execution (i.e. from OSX to Linux) #11148

stuhood opened this issue Nov 12, 2020 · 3 comments
Assignees

Comments

@stuhood
Copy link
Member

stuhood commented Nov 12, 2020

This was designed in https://docs.google.com/document/d/1hS0n6vp-hBxy4Xo-q9QA_elofzQtOubjfN4nSeIgp90/edit#

@stuhood
Copy link
Member Author

stuhood commented Sep 14, 2022

I've added a section to https://docs.google.com/document/d/1vXRHWK7ZjAIp2BxWLwRYm1QOKDeXx02ONQWvXDloxkg/edit#heading=h.w0bkj2kpqzfq which describes how environment matchers should likely support this.

@stuhood
Copy link
Member Author

stuhood commented Oct 4, 2022

I've confirmed that this is working via #7735: huzzah! Thanks @Eric-Arellano, @chrisjrn, @tdyas.

Before calling this resolved though, I'll need to think about how we can migrate from the current "--remote-execution enables remote execution everywhere" world, to a world where that is accomplished via environments, as described in #17096 (which is not currently accurate).

@stuhood
Copy link
Member Author

stuhood commented Oct 5, 2022

Ok, after talking with @Eric-Arellano, it sounds like they had already included some backwards compatibility for the --remote-execution flag. So this one was probably already resolvable as soon as they made that change =)

My next change is going to be #17129 to help clarify which scopes environments need to be lifted from.

@stuhood stuhood closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants