Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs calculation occurs outside of StreamingWorkunit plugin scope #16146

Closed
stuhood opened this issue Jul 12, 2022 · 1 comment
Closed

Specs calculation occurs outside of StreamingWorkunit plugin scope #16146

stuhood opened this issue Jul 12, 2022 · 1 comment
Labels
Milestone

Comments

@stuhood
Copy link
Member

stuhood commented Jul 12, 2022

On 2.13.x, specs calculation is seemingly occurring outside of the StreamingWorkunit plugin's scope. All of the workunits are still handled, but the plugin doesn't receive its first call until after the specs have been calculated and the rest of the run is starting.

@stuhood stuhood added this to the 2.13.x milestone Jul 12, 2022
@stuhood
Copy link
Member Author

stuhood commented Jul 12, 2022

Hm, apparently it has always been this way, because the StreamingWorkunitHandler constructor actually takes the constructed specs. To fix this, I think that we'll need to fix #13757, which will make the specs a calculated value to be used in get_expanded_specs, rather than a pre-computed value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant