Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule parser doesn't handle attribute arguments #16868

Closed
thejcannon opened this issue Sep 14, 2022 · 0 comments · Fixed by #16948
Closed

rule parser doesn't handle attribute arguments #16868

thejcannon opened this issue Sep 14, 2022 · 0 comments · Fixed by #16948
Assignees
@thejcannon
Labels
bug

Comments

@thejcannon
Copy link
Member

Describe the bug

Get(Foo, Bar.Baz, ...)

produces:

pants.engine.internals.selectors.GetParseError: Invalid Get. Because you are using the longhand form Get(OutputType, InputType, input), the second argument should be a type, like `MergeDigests` or `Process`. Failed for Get(Foo, <class '_ast.Attribute'>, ...)

Pants version
main

OS
Both

Additional info
N/A
@thejcannon thejcannon added the bug label Sep 14, 2022
@thejcannon thejcannon changed the title rule parser doens't handle attribute arguments rule parser doesn't handle attribute arguments Sep 14, 2022
@thejcannon thejcannon self-assigned this Sep 21, 2022
@thejcannon thejcannon mentioned this issue Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thejcannon thejcannon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for attribute lookup in rule parsing thejcannon/pants
1 participant
@thejcannon