Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should partition (but likely not batch) check inputs #17328

Open
thejcannon opened this issue Oct 22, 2022 · 6 comments
Open

We should partition (but likely not batch) check inputs #17328

thejcannon opened this issue Oct 22, 2022 · 6 comments

Comments

@thejcannon
Copy link
Member

Describe the bug
fmt lint fix and test (soon) are all partitioning their inputs on plugin-provided criteria.

mypy is a great example of this, and I think it helps the code to have the split be built-in to the core rule.

@thejcannon thejcannon added the bug label Oct 22, 2022
@sureshjoshi
Copy link
Member

cough... pyright... cough cough...

@stuhood
Copy link
Member

stuhood commented Oct 24, 2022

Agreed. #17315 also suggests that we should be partitioning in check rather than in implementations.

@stuhood stuhood added bug and removed bug labels Oct 24, 2022
@stuhood
Copy link
Member

stuhood commented Oct 24, 2022

I'm not sure that the "bug" label is accurate though, as all implementations which need partitioning are already doing it internally.

@thejcannon
Copy link
Member Author

Oh feel free to change the label 😛

@stuhood stuhood removed the bug label Oct 24, 2022
@chrisjrn
Copy link
Contributor

Per #17315, whatever partitioning mechanism exists should be able to partition based on environment field, and there should be a facility to ask for this at the @goal_rule level.

@thejcannon
Copy link
Member Author

What makes check different from fmt/fix/lint in this regard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants