Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to zinc's built-in fingerprinting #4754

Closed
stuhood opened this issue Jul 18, 2017 · 1 comment
Closed

Switch to zinc's built-in fingerprinting #4754

stuhood opened this issue Jul 18, 2017 · 1 comment

Comments

@stuhood
Copy link
Sponsor Member

stuhood commented Jul 18, 2017

After sbt/zinc#371 lands and is released (with anything other than SHA1), we should switch to the built in fingerprinting rather than using filename+timestamp as we do now (which was only intended as a short lived hack).

pants/src/scala/org/pantsbuild/zinc/cache/FileFPrint.scala

Line 27 in 61c01d4

/**

@stuhood stuhood added the jvm label Jul 18, 2017
@stuhood
Copy link
Sponsor Member Author

stuhood commented May 8, 2018

@jvican: Fiiiinally getting around to this.

What ended up being the result of sbt/zinc#371 and sbt/zinc#452 ? Is there any particular configuration required to enable this hashing?

@benjyw benjyw closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuhood @benjyw