Replace use of os.unsetenv(...) with del os.environ[...] #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems perfectly reasonable to me and still cleanly merges. I'm sure windows support would be an uphill battle, but definitely something we should entertain for inclusivity. |
wickman
added a commit
that referenced
this pull request
Nov 21, 2014
Replace use of os.unsetenv(...) with del os.environ[...]
wickman
added a commit
to pantsbuild/pants
that referenced
this pull request
Dec 4, 2014
SSIA. The user facing parts of this change:
- package resolution happens via requests now -- this is way more reliable
and results in fewer Untranslateable exceptions
- PEX_VERBOSE now controls all pex verbosity, including better messages around Untranslateable (yay!)
- fixes a major pex regression with namespace packages introduced somewhere in 0.5.x
The pex 0.7.0 -> 0.8.0 changelog:
* *API change*: Decouple translation from package iteration. This removes
the Obtainer construct entirely, which likely means if you're using PEX as
a library, you will need to change your code if you were doing anything
nontrivial. This adds a couple new options to ``resolve`` but simplifies
the story around how to cache packages.
[RB #785](https://rbcommons.com/s/twitter/r/785/)
* Refactor http handling in pex to allow for alternate http implementations. Adds support
for [requests](https://github.com/kennethreitz/requests),
improving both performance and security. For more information, read the commit notes at
[91c7f32](pex-tool/pex@91c7f32).
[RB #778](https://rbcommons.com/s/twitter/r/778/)
* Improvements to API documentation throughout.
* Renamed ``Tracer`` to ``TraceLogger`` to prevent nondeterministic isort ordering.
* Refactor tox.ini to increase the number of environment combinations and improve coverage.
* Adds HTTP retry support for the RequestsContext.
[RB #1303](https://rbcommons.com/s/twitter/r/1303/)
* Make pex --version correct.
[Issue #19](pex-tool/pex#19)
* Bug fix: Fix over-aggressive sys.modules scrubbing for namespace packages. Under
certain circumstances, namespace packages in site-packages could conflict with packages
within a PEX, causing them to fail importing.
[RB #1378](https://rbcommons.com/s/twitter/r/1378/)
* Bug fix: Replace uses of ``os.unsetenv(...)`` with ``del os.environ[...]``
[Pull Request #11](pex-tool/pex#11)
* Bug fix: Scrub sys.path and sys.modules based upon both supplied path and
realpath of files and directories. Newer versions of virtualenv on Linux symlink site-packages
which caused those packages to not be removed from sys.path correctly.
[Issue #21](pex-tool/pex#21)
* Bug fix: The pex -s option was not correctly pulling in transitive dependencies.
[Issue #22](pex-tool/pex#22)
* Bug fix: Adds ``content`` method to HTTP contexts that does HTML content decoding, fixing
an encoding issue only experienced when using Python 3.
[Issue #10](pex-tool/pex#10)
Testing Done:
build-support/bin/ci.sh
Reviewed at https://rbcommons.com/s/twitter/r/1421/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.