fix(typescript): add missing types #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
requested changes
Sep 1, 2020
types/index.d.ts
Outdated
Comment on lines
72
to
73
| scopes_supported?: string[]; | ||
|
|
There was a problem hiding this comment.
scopes_supported is not an IANA registered client metadata property. Please remove this blob.
scopes_supported could potentially go to the IssuerMetadata interface, but as the library never reacts to its presence it's not included. I'm keen to only include properties that change the client/issuer behaviour. So it's either all or nothing and i think the inclusion of [key: string]: unknown; handles all possible metadata for anyone.
| @@ -346,6 +347,7 @@ export class Client { | |||
| [custom.http_options]: CustomHttpOptionsProvider; | |||
| [custom.clock_tolerance]: number; | |||
| metadata: ClientMetadata; | |||
| issuer: Issuer<this>; | |||
There was a problem hiding this comment.
there's also a static version of it, please add that too.
|
Thanks for the detailed review! |
panva
reviewed
Sep 2, 2020
panva
reviewed
Sep 2, 2020
|
@jaulz thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some helpful properties were missing in the types.