From 9c4f446be703dc846d9932afb6bb96838fb88686 Mon Sep 17 00:00:00 2001 From: Julian Hundeloh Date: Tue, 1 Sep 2020 17:33:29 +0200 Subject: [PATCH 1/7] fix: add missing types --- types/index.d.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index 7980e738..8aa3a13a 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -69,7 +69,8 @@ export interface ClientMetadata { authorization_encrypted_response_alg?: string; authorization_encrypted_response_enc?: string; authorization_signed_response_alg?: string; - + scopes_supported?: string[]; + [key: string]: unknown; } @@ -346,6 +347,7 @@ export class Client { [custom.http_options]: CustomHttpOptionsProvider; [custom.clock_tolerance]: number; metadata: ClientMetadata; + issuer: Issuer; /** * Returns the target authorization redirect URI to redirect End-Users to using the provided parameters. From d83295fb50be8a1e6d579acdca21ee4709bf0be0 Mon Sep 17 00:00:00 2001 From: Julian Hundeloh Date: Tue, 1 Sep 2020 17:34:53 +0200 Subject: [PATCH 2/7] fix: add generic --- types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index 8aa3a13a..823c32af 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -347,7 +347,7 @@ export class Client { [custom.http_options]: CustomHttpOptionsProvider; [custom.clock_tolerance]: number; metadata: ClientMetadata; - issuer: Issuer; + issuer: Issuer; /** * Returns the target authorization redirect URI to redirect End-Users to using the provided parameters. From 49f7e99aa01ffd619dc8d11e7bef3ff9dc686d1a Mon Sep 17 00:00:00 2001 From: Julian Hundeloh Date: Tue, 1 Sep 2020 21:12:46 +0200 Subject: [PATCH 3/7] fix: remove supported_scopes and add static issuer --- types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index 823c32af..3e1f591d 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -69,7 +69,6 @@ export interface ClientMetadata { authorization_encrypted_response_alg?: string; authorization_encrypted_response_enc?: string; authorization_signed_response_alg?: string; - scopes_supported?: string[]; [key: string]: unknown; } @@ -348,6 +347,7 @@ export class Client { [custom.clock_tolerance]: number; metadata: ClientMetadata; issuer: Issuer; + static issuer: Issuer; /** * Returns the target authorization redirect URI to redirect End-Users to using the provided parameters. From bff397c0c9eb1d0f703b89e6b7a5dce7b0eb5ec7 Mon Sep 17 00:00:00 2001 From: Julian Hundeloh Date: Tue, 1 Sep 2020 21:13:09 +0200 Subject: [PATCH 4/7] style: remove whitespaces --- types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index 3e1f591d..d984402c 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -69,7 +69,7 @@ export interface ClientMetadata { authorization_encrypted_response_alg?: string; authorization_encrypted_response_enc?: string; authorization_signed_response_alg?: string; - + [key: string]: unknown; } From 0c1c23e7348a4be66f3e4978f0d6dd3161655972 Mon Sep 17 00:00:00 2001 From: Julian Hundeloh Date: Tue, 1 Sep 2020 21:24:52 +0200 Subject: [PATCH 5/7] fix: remove this in static property --- types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index d984402c..58421d47 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -347,7 +347,7 @@ export class Client { [custom.clock_tolerance]: number; metadata: ClientMetadata; issuer: Issuer; - static issuer: Issuer; + static issuer: Issuer; /** * Returns the target authorization redirect URI to redirect End-Users to using the provided parameters. From 3b40cb0616e1b9bee6c477f5cbe2b3e477130c65 Mon Sep 17 00:00:00 2001 From: Filip Skokan Date: Wed, 2 Sep 2020 08:21:22 +0200 Subject: [PATCH 6/7] Apply suggestions from code review --- types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index 58421d47..1b0825d6 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -347,7 +347,7 @@ export class Client { [custom.clock_tolerance]: number; metadata: ClientMetadata; issuer: Issuer; - static issuer: Issuer; + static issuer: Issuer; /** * Returns the target authorization redirect URI to redirect End-Users to using the provided parameters. From cdea4eae62c0f559add5a83170f20ca2d2d55f34 Mon Sep 17 00:00:00 2001 From: Filip Skokan Date: Wed, 2 Sep 2020 09:29:28 +0200 Subject: [PATCH 7/7] Apply suggestions from code review --- types/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/index.d.ts b/types/index.d.ts index 1b0825d6..58421d47 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -347,7 +347,7 @@ export class Client { [custom.clock_tolerance]: number; metadata: ClientMetadata; issuer: Issuer; - static issuer: Issuer; + static issuer: Issuer; /** * Returns the target authorization redirect URI to redirect End-Users to using the provided parameters.