Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optimism re-export in reth-primitives #11434

Closed
Tracked by #7649
emhane opened this issue Oct 2, 2024 · 1 comment · Fixed by #11438
Closed
Tracked by #7649

Remove optimism re-export in reth-primitives #11434

emhane opened this issue Oct 2, 2024 · 1 comment · Fixed by #11438
Labels
A-dependencies Pull requests or issues that are about dependencies A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain

Comments

@emhane
Copy link
Member

emhane commented Oct 2, 2024

Describe the feature

Remove re-export of optimism types from reth-primitives

reth/crates/primitives/src/lib.rs

Lines 81 to 89 in 2ca8231

/// Optimism specific re-exports
#[cfg(feature = "optimism")]
mod optimism {
pub use crate::transaction::{optimism_deposit_tx_signature, TxDeposit, DEPOSIT_TX_TYPE_ID};
pub use reth_optimism_chainspec::{BASE_MAINNET, BASE_SEPOLIA, OP_MAINNET, OP_SEPOLIA};
}
#[cfg(feature = "optimism")]
pub use optimism::*;

Additional context

No response
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-dependencies Pull requests or issues that are about dependencies A-op-reth Related to Optimism and op-reth labels Oct 2, 2024
@emhane emhane mentioned this issue Oct 2, 2024
Open
@jancris100
Copy link

can you assign this to me?

@tcoratger tcoratger mentioned this issue Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

primitives: remove optimism re-export in reth-primitives tcoratger/reth
2 participants
@emhane @jancris100