Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more trace internal types #5349

Closed
jasalper opened this issue Nov 8, 2023 · 1 comment · Fixed by #5545
Closed

Expose more trace internal types #5349

jasalper opened this issue Nov 8, 2023 · 1 comment · Fixed by #5545
Labels
C-enhancement New feature or request

Comments

@jasalper
Copy link

jasalper commented Nov 8, 2023

Describe the feature

The tracing code is currently written with the json-rpc in mind - the exposed types are easily serializable. But if one wishes to use the Revm inspectors directly, much of the information generated is hidden behind the parity/geth trace conversions.

Without an API in mind yet, it would be nice to expose some of the internal types for ease of manipulation to avoid conversion to the json-rpc api and back.

Two example use cases:

  • I have some transaction that reverts. I'd like to bubble up the internal calls that led to this revert. CallTraceNode has useful fields like parent/children, but it is not available. Instead, the CallTraceNodes are converted into TransactionTrace types for serialization, and the trace_address fields need to be parsed back and converted into the tree to find parents.
  • I want both the VMTrace and the CallTraces. But I create an Inspector, and need to convert it to either a parity builder or a geth builder to be able to see the results of the trace - both of which consume the inspector.

Additional context

No response

@jasalper jasalper added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 8, 2023
@mattsse
Copy link
Collaborator

mattsse commented Nov 8, 2023

sg!
I think we need to make them public anyway for foundry

@DaniPopes DaniPopes removed the S-needs-triage This issue needs to be labelled label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants