You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
emhane opened this issue
Jun 12, 2024
· 1 comment
· Fixed by #9444
Labels
A-op-rethRelated to Optimism and op-rethA-rpcRelated to the RPC implementationC-debtRefactor of code section that is hard to understand or maintainS-blockedThis cannot more forward until something else changes
Make type that impl EthApiServer configurable, by adding as GAT to extension trait of FullNodeComponents. EthHandlers needs to be generic over a type that implements this extension trait , and as a follow so does RpcRegistry.
The text was updated successfully, but these errors were encountered:
emhane
added
C-debt
Refactor of code section that is hard to understand or maintain
A-rpc
Related to the RPC implementation
A-op-reth
Related to Optimism and op-reth
labels
Jun 12, 2024
emhane
changed the title
Add EthApi as GAT of NodeComponents
Add EthHandlers as GAT of NodeComponentsJun 17, 2024
emhane
changed the title
Add EthHandlers as GAT of NodeComponents
Add EthHandlers as GAT of ~~NodeComponents~~ NodeComponentsExtJun 20, 2024
emhane
changed the title
Add EthHandlers as GAT of ~~NodeComponents~~ NodeComponentsExt
Add EthHandlers as GAT of NodeComponents extension trait
Jun 20, 2024
emhane
changed the title
Add EthHandlers as GAT of NodeComponents extension trait
Add EthApiServer as GAT of NodeComponents extension trait
Jun 20, 2024
A-op-rethRelated to Optimism and op-rethA-rpcRelated to the RPC implementationC-debtRefactor of code section that is hard to understand or maintainS-blockedThis cannot more forward until something else changes
Describe the feature
Build
EthApi
andEngineEthApi
according to Reth's node builder patternreth/crates/node/builder/src/components/mod.rs
Lines 30 to 65 in b8cd7be
Make type that impl
EthApiServer
configurable, by adding as GAT to extension trait ofFullNodeComponents
.EthHandlers
needs to be generic over a type that implements this extension trait , and as a follow so doesRpcRegistry
.Additional context
blocked by #8985
The text was updated successfully, but these errors were encountered: