Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove test-utils features from binary #8837

Closed
mattsse opened this issue Jun 14, 2024 · 1 comment
Closed

remove test-utils features from binary #8837

mattsse opened this issue Jun 14, 2024 · 1 comment
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 14, 2024

Describe the feature

a few crates are enabled with test-utils:

reth-nippy-jar
reth-transaction-pool
reth-provider
reth-stages-api
reth-db

which causes a ripple-effect and pulls in a ton of test specific stuff, e.g. proptest and more derives.
a lot of these could be phased out, I believe we're using a bunch of noopstuff in a few cli commands

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 14, 2024
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain and removed S-needs-triage This issue needs to be labelled labels Jun 14, 2024
@mattsse
Copy link
Collaborator Author

mattsse commented Jun 14, 2024

actually we dont use test-utils here

@mattsse mattsse closed this as completed Jun 14, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 14, 2024
@DaniPopes DaniPopes mentioned this issue Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattsse