Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single block iterator for ExEx backfill #9172

Closed
shekhirin opened this issue Jun 28, 2024 · 1 comment · Fixed by #9245
Closed

Single block iterator for ExEx backfill #9172

shekhirin opened this issue Jun 28, 2024 · 1 comment · Fixed by #9245
Assignees
Labels
A-exex Execution Extensions C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

Currently, we only have an iterator that iterates in batches and yields the next iterator value when the batch has finished executing:

/// It implements [`Iterator`] that executes blocks in batches according to the provided thresholds
/// and yields [`Chain`]

We need to add another iterator that yields just the (Block, ExecutionOutcome). I propose the following API:

let factory = BackfillJobFactory::new(...);
let backfill = factory.backfill(range).into_single_blocks();
for (block, outcome) in backfill {
   ...
}

into_single_blocks will return another type of iterator that executes blocks one by one, and returns (Block, ExecutionOutcome) instead of the whole Chain.

Additional context

No response

@shekhirin shekhirin added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-exex Execution Extensions labels Jun 28, 2024
@greged93
Copy link
Contributor

hey @shekhirin, I'm down to take this if I may

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants