Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cli utils to cli-util crate #9260

Closed
Tracked by #7576
mattsse opened this issue Jul 3, 2024 · 1 comment · Fixed by #9297
Closed
Tracked by #7576

move cli utils to cli-util crate #9260

mattsse opened this issue Jul 3, 2024 · 1 comment · Fixed by #9297
Assignees
Labels
A-cli Related to the reth CLI D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 3, 2024

TODO move more utils to commonly used cli-utils crate (new crate)

this includes:

mod secret_key;
pub use secret_key::{get_secret_key, SecretKeyError};

various parse fns

pub fn parse_socket_address(value: &str) -> eyre::Result<SocketAddr, SocketAddressParsingError> {

pub fn hash_or_num_value_parser(value: &str) -> eyre::Result<BlockHashOrNumber, eyre::Error> {

pub fn parse_duration_from_secs(arg: &str) -> eyre::Result<Duration, std::num::ParseIntError> {

cc @loocapro

@mattsse mattsse changed the title move cli utils to cli crate move cli utils to cli-util crate Jul 3, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-cli Related to the reth CLI labels Jul 3, 2024
@loocapro
Copy link
Contributor

loocapro commented Jul 3, 2024

I can do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants