Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: UI for failure setting ERC20 balance #60

Closed
jxom opened this issue Sep 14, 2023 · 2 comments
Closed

Enhancement: UI for failure setting ERC20 balance #60

jxom opened this issue Sep 14, 2023 · 2 comments
Labels
D: Easy Difficulty: Easy Good First Issue Good for newcomers P: Medium Priority: Medium T: Enhancement Type: Enhancement

Comments

@jxom
Copy link
Member

jxom commented Sep 14, 2023

Depends on #58

The Request

The ability to see feedback in the UI when a failure occurs while a user is trying to set an ERC20 balance.

Problem

Right now, balanceOf storage slot guessing can fail for some ERC20 tokens that wildly deviate from the ERC20 interface. For these tokens, when a user tries to set a balance for them, no messaging/feedback is provided.

Solution

As a user, when I set a balance for one of my ERC20 tokens on the token list screen, I would expect to see some error messaging (in the form of a toast message) in the UI to tell me that setting a balance failed, and for the input field to become disabled.

Notes

See TODO

@jxom jxom added Good First Issue Good for newcomers P: Medium Priority: Medium D: Easy Difficulty: Easy T: Enhancement Type: Enhancement labels Sep 14, 2023
@About7Sharks
Copy link

Is this issue still Open?
#68 Looks like this PR should have closed it?

@jxom
Copy link
Member Author

jxom commented Sep 20, 2023

There is currently no UI to display error states for setting balances yet!

@jxom jxom closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: Easy Difficulty: Easy Good First Issue Good for newcomers P: Medium Priority: Medium T: Enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants