From f41847ee4f78b700d7b0f30350e17789e817ad49 Mon Sep 17 00:00:00 2001 From: Grundik Date: Thu, 18 Jan 2024 22:12:48 +0300 Subject: [PATCH] Fix: unreachable code typo --- src/Base64.php | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/Base64.php b/src/Base64.php index e090613..e75aa4f 100644 --- a/src/Base64.php +++ b/src/Base64.php @@ -245,18 +245,12 @@ public static function decodeNoPadding( return ''; } if (($srcLen & 3) === 0) { - if ($encodedString[$srcLen - 1] === '=') { + // If $strLen is not zero and it is divisible by 4, then its at least 4. + if ($encodedString[$srcLen - 1] === '=' || $encodedString[$srcLen - 2] === '=') { throw new InvalidArgumentException( "decodeNoPadding() doesn't tolerate padding" ); } - if (($srcLen & 3) > 1) { - if ($encodedString[$srcLen - 2] === '=') { - throw new InvalidArgumentException( - "decodeNoPadding() doesn't tolerate padding" - ); - } - } } return static::decode( $encodedString,