Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context2D does not implement rect() correctly #3409

Open
andrewcmyers opened this issue Apr 9, 2022 · 5 comments
Open

Context2D does not implement rect() correctly #3409

andrewcmyers opened this issue Apr 9, 2022 · 5 comments
Labels
Bug difficulty:beginner help wanted

Comments

@andrewcmyers
Copy link
Contributor

It should add a closed subpath with four segments. Instead, it adds an open subpath with six segments.
@HackbrettXXX
Copy link
Collaborator

Thanks for the report. Could you prepare a PR?

@andrewcmyers
Copy link
Contributor Author

Previous experience with doing a PR for #3273 has not been fruitful.

@andrewcmyers andrewcmyers mentioned this issue Apr 14, 2022
Closed
@nicolashacala nicolashacala mentioned this issue Oct 24, 2022
Closed
@Mayank1728
Copy link

would like to grab. please can you tell me exactly what needs to be done ?

@andrewcmyers
Copy link
Contributor Author

There already two PRs to fix this. I think the test cases just need to be updated on one of them.

@andrewcmyers
Copy link
Contributor Author

I think my fix is more correct fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug difficulty:beginner help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewcmyers @HackbrettXXX @Mayank1728