Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contour CRDs are installing even when contour dependency is disabled #13

Open
akshay196-rafay opened this issue Apr 28, 2022 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@akshay196-rafay
Copy link
Contributor

akshay196-rafay commented Apr 28, 2022

This issue is referring to the changes made in PR #14.

The contour subchart addition comes with its CRDs which are currently placed in the crds/ directory of this chart. The reason we kept crds in our own chart is to solve unable to recognize HTTPProxy kind error. (same error as mentioned in this issue)

These CRDs are installed independently whether a user enabled contour dependency or not. The --skip-crds option to helm install command skips installing crds. But currently we don't have option to manage CRDs based on enable/disable state of dependencies.

Potential solutions:

  1. Separate chart for CRDs as suggested here.
  2. Apply --skip-crds flag when installing chart with contour dependency turned off.
@akshay196-rafay akshay196-rafay self-assigned this Apr 28, 2022
@akshay196-rafay akshay196-rafay changed the title Contour CRDs are installed even when deploy.contour.enable is false Contour CRDs are installing even when deploy.contour.enable is false Apr 28, 2022
@akshay196-rafay
Copy link
Contributor Author

Separate chart for CRDs as suggested here.

Due to this known issue of Helm, the CRDs will still be installed even when dependency if turned off.

Apply --skip-crds flag when installing chart with contour dependency turned off.

This is an easy solution I can think of right now. We will document this in the our chart installation.

@akshay196-rafay akshay196-rafay changed the title Contour CRDs are installing even when deploy.contour.enable is false Contour CRDs are installing even when contour dependency is disabled May 2, 2022
@akshay196 akshay196 added the wontfix This will not be worked on label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants